fix max bytes dealloc bug #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpuller
commented
Oct 28, 2024
| @@ -1802,7 +1805,6 @@ class spark_resource_adaptor final : public rmm::mr::device_memory_resource { | |||
| if (is_for_cpu == t_state.is_cpu_alloc) { | |||
| transition(t_state, thread_state::THREAD_ALLOC_FREE); | |||
| } | |||
| if (!is_for_cpu) { t_state.gpu_memory_allocated_bytes -= num_bytes; } | |||
There was a problem hiding this comment.
I didn't notice in the original change that this code path is only running on other threads which is incorrect for the tracking behavior (see line 1787)
Signed-off-by: Zach Puller <[email protected]>
revans2
approved these changes
Oct 28, 2024
|
build |
YanxuanLiu
added a commit
to YanxuanLiu/spark-rapids-jni
that referenced
this pull request
Dec 10, 2024
These files are modified in NVIDIA#2541 and NVIDIA#2562 but did not update year of copyright Signed-off-by: Yanxuan Liu <[email protected]>
YanxuanLiu
added a commit
that referenced
this pull request
Dec 10, 2024
These files are modified in #2541 and #2562 but did not update year of copyright Signed-off-by: Yanxuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #2392 to fix how we handle the deallocation path.
I verified that the deallocate behavior looks correct now, that is, if a job spills and reallocs, the metric never reports a watermark above the memory limit. The unit test change also verifies this case.